Gaulish Gaming Banquet: editor

adrientd

Yeah, this is still to be added, I think I will also take the opportunity to add this information in the json and read it from here.

adrientd

So that it can be changed later when we learn more about the ground flags.

adrientd

And could be useful for later games where the flags might have changed.

pegperegogaucho

Adrien, you should consider changing the condition inside window.cpp to ```c++ !(SDL_GetWindowFlags(_sw) & SDL_WINDOW_INPUT_FOCUS) ``` Because right now it only pauses when you actually click the minimize button. If you tab out or cover the window with others it will still run

adrientd

That would be it will stop render when not on focus, but that will have some noticeable changes: - when hovering elements the color won't change when the window is not on focus (the editor might seem frozen) - and of course, beacons won't animate anymore.

adrientd

I know it might seem useless, but I do have to point up as we do lose something when doing that.

adrientd

So I guess you really don't want to waste CPU time when it's not on focus :Obelul:

deathhound246

uh i just rebased these changes onto my alice-dev stuff and now opening anything in hex view crashes :Obelul:

adrientd

But maybe I might also just limit the FPS, so at least it would still render and react to the mouse a bit while not stressing the CPU a lot

adrientd

To be fair I haven't tested :Obelul:

deathhound246

it didnt look like much had been changed tbf, but i also was near 40 commits behind :Obelul:

deathhound246

is there anyway i can see *where* it's crashing? it's only saying `abort() was called`

deathhound246

acc, clicking retry showed me this

adrientd

Indeed I just tested and it crashed with as assert failure `(flags & ImGuiInputTextFlags_EnterReturnsTrue) == 0`, not sure why something doesn't want an input box to have Enter return true.

deathhound246

the only text box in hex view is level number though i think

deathhound246

and why is it being checked when clicking on an object to show its bytes :Obelul:

deathhound246

are the objects in this list null?

adrientd

The real question is why it thinks it crashed here in CKHkWeatherCenter

adrientd

I'm not even sure if that is used with Alice

deathhound246

I don't think it is

#editor